mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 16235: Added os::bootId.
Date Fri, 13 Dec 2013 19:32:13 GMT


> On Dec. 13, 2013, 5:15 a.m., Ian Downes wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 925
> > <https://reviews.apache.org/r/16235/diff/1/?file=397417#file397417line925>
> >
> >     Move endutxent() above here so it's always closed?

Thank you! My plan is to re-work this to support OS X (via sysctl) / Linux (via uuid) and
leave POSIX as a TODO due to the thread safety issues of utmpx.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16235/#review30332
-----------------------------------------------------------


On Dec. 13, 2013, 4:25 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16235/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2013, 4:25 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-844
>     https://issues.apache.org/jira/browse/MESOS-844
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This can be used to identify a reboot, should the boot id change.
> 
> For POSIX systems, the boot time in seconds is used as a good approximation.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 2382d40a51036782e09e1fc3123c8791834510ea

>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp a0b624b0c2e1f1fca6dd68a54317f6c0c11e7862

> 
> Diff: https://reviews.apache.org/r/16235/diff/
> 
> 
> Testing
> -------
> 
> Added a test, make check on OS X and CentOS 5.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message