mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy St. Clair" <tstcl...@redhat.com>
Subject Re: Review Request 15764: Minor fix for script-without-shebang MESOS-831
Date Fri, 06 Dec 2013 20:31:22 GMT


> On Nov. 22, 2013, 9:51 p.m., Ben Mahler wrote:
> > Interesting, these files are not meant to be scripts (they are python libraries),
which tool reported the script-without-shebang issue?
> > 
> > (Can you kill the trailing whitespace in the Apache header?)
> 
> Timothy St. Clair wrote:
>     rpmlint generated on recent update (https://bugzilla.redhat.com/show_bug.cgi?id=1010512#c6).
 It checks the contents of the install targets.

Updated patch to remove minor trailing spaces.  There were only a couple. 


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15764/#review29316
-----------------------------------------------------------


On Nov. 21, 2013, 7:07 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15764/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, 7:07 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-831
>     https://issues.apache.org/jira/browse/MESOS-831
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Minor modification to python scripts. 
> 
> 
> Diffs
> -----
> 
>   src/cli/python/mesos/__init__.py e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 
>   src/cli/python/mesos/cli.py 5c11d4664de4314674cb49cf534e334a0663b254 
>   src/cli/python/mesos/futures.py be374cf0235de75f7201b3e8078af8cef620dc2f 
>   src/cli/python/mesos/http.py 9db9e23c731c4306ff3866c07963a19c196f758c 
> 
> Diff: https://reviews.apache.org/r/15764/diff/
> 
> 
> Testing
> -------
> 
> n/a
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message