mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 15954: Fix cgroup code to use processes rather than threads
Date Tue, 03 Dec 2013 01:51:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15954/#review29637
-----------------------------------------------------------



src/linux/cgroups.cpp
<https://reviews.apache.org/r/15954/#comment57046>

    Perhaps a note here about thread group ids and the lack of guarantees:
    
     - cgroup.procs: list of thread group IDs in the cgroup.  This list is
       not guaranteed to be sorted or free of duplicate TGIDs, and userspace
       should sort/uniquify the list if this property is required.
       Writing a thread group ID into this file moves all threads in that
       group into this cgroup.


- Ben Mahler


On Dec. 3, 2013, 1:34 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15954/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 1:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> the cgroup "tasks" file lists the *threads* in a cgroup. we should use the "cgroup.procs"
which lists processes.
> 
> see https://issues.apache.org/jira/browse/MESOS-859
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp 6f60c43 
>   src/linux/cgroups.cpp 5a95e75 
>   src/tests/cgroups_tests.cpp bc5f961 
> 
> Diff: https://reviews.apache.org/r/15954/diff/
> 
> 
> Testing
> -------
> 
> make check # on linux
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message