Return-Path: 
 <dev-return-15328-apmail-mesos-dev-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-dev-archive@www.apache.org
Delivered-To: apmail-mesos-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 1A12C10CF6
	for <apmail-mesos-dev-archive@www.apache.org>;
 Fri,  8 Nov 2013 21:42:57 +0000 (UTC)
Received: (qmail 99709 invoked by uid 500); 8 Nov 2013 21:42:57 -0000
Delivered-To: apmail-mesos-dev-archive@mesos.apache.org
Received: (qmail 99680 invoked by uid 500); 8 Nov 2013 21:42:56 -0000
Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@mesos.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@mesos.apache.org>
List-Post: <mailto:dev@mesos.apache.org>
List-Id: <dev.mesos.apache.org>
Reply-To: dev@mesos.apache.org
Delivered-To: mailing list dev@mesos.apache.org
Received: (qmail 99668 invoked by uid 99); 8 Nov 2013 21:42:56 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Nov 2013 21:42:56 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id D0E241D3932;
	Fri,  8 Nov 2013 21:42:53 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============6664718704753636961=="
MIME-Version: 1.0
Subject: Re: Review Request 15333: Added Owned<T>::share().
From: "Ben Mahler" <benjamin.mahler@gmail.com>
To: "Benjamin Hindman" <benh@berkeley.edu>,
 "Ben Mahler" <benjamin.mahler@gmail.com>, "Vinod Kone" <vinodkone@gmail.com>
Cc: "Jie Yu" <yujie.jay@gmail.com>, "mesos" <dev@mesos.apache.org>
Date: Fri, 08 Nov 2013 21:42:53 -0000
Message-ID: <20131108214253.28852.32255@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Ben Mahler" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-ReviewRequest-URL: https://reviews.apache.org/r/15333/
X-Sender: "Ben Mahler" <noreply@reviews.apache.org>
References: <20131108013101.30022.47032@reviews.apache.org>
In-Reply-To: <20131108013101.30022.47032@reviews.apache.org>
Reply-To: "Ben Mahler" <benjamin.mahler@gmail.com>

--===============6664718704753636961==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15333/#review28578
-----------------------------------------------------------


Why did you move this into libprocess?

Can you split this change into separate reviews for libprocess / stout / mesos?

- Ben Mahler


On Nov. 8, 2013, 1:30 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15333/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2013, 1:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> Renamed to Shared<T>::upgrade to Shared<T>::own().
> 
> Also, moved owned.hpp to libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 47e8dbb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/owned.hpp 3433f50 
>   3rdparty/libprocess/Makefile.am d348780 
>   3rdparty/libprocess/include/process/owned.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/shared.hpp e0c7991 
>   3rdparty/libprocess/include/process/statistics.hpp fbae641 
>   3rdparty/libprocess/src/tests/owned_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/shared_tests.cpp 860a9aa 
>   3rdparty/libprocess/src/tests/statistics_tests.cpp 8695f45 
>   src/master/master.hpp e377af8 
>   src/master/master.cpp 8e14a07 
>   src/sched/sched.cpp 3abe72f 
>   src/slave/gc.hpp 083aa79 
>   src/slave/monitor.cpp 9cb6256 
>   src/slave/reaper.hpp 4498139 
>   src/slave/slave.hpp 68526f3 
>   src/tests/cluster.hpp bea395a 
> 
> Diff: https://reviews.apache.org/r/15333/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


--===============6664718704753636961==--