mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 15169: Expose git sha and branch in master and slave state.json
Date Wed, 27 Nov 2013 00:33:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15169/
-----------------------------------------------------------

(Updated Nov. 27, 2013, 12:33 a.m.)


Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Changes
-------

Per discussion, patch now includes git_tag field.


Repository: mesos-git


Description
-------

Exposing build revisions and branch names can help diagnosing problems with slaves and masters
in development settings.

This patch fetches git sha and branch of repo (if available) and fills option variables BUILD_GIT_SHA
and BUILD_GIT_BRANCH accordingly.
If variables are set, master and slave state.json expose and sets fields "git_sha" and "git_branch".


Diffs (updated)
-----

  configure.ac ba4ec1d 
  src/Makefile.am abef3d2 
  src/common/build.hpp c0e2a64 
  src/common/build.cpp 960b017 
  src/master/http.cpp 218906a 
  src/slave/http.cpp fbc917b 

Diff: https://reviews.apache.org/r/15169/diff/


Testing
-------

make check

Functional testing of:
1) Development version (from git repo) -> Shows correct git hash and branch
2) Distribution version (from make dist) -> Does *not* show git hash and branch fields
in state.json


Thanks,

Niklas Nielsen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message