mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 15773: Fixed master to ignore messages from unregistered framework.
Date Mon, 25 Nov 2013 20:05:41 GMT


> On Nov. 25, 2013, 7:07 p.m., Ben Mahler wrote:
> > src/master/master.cpp, line 1045
> > <https://reviews.apache.org/r/15773/diff/2/?file=390839#file390839line1045>
> >
> >     Looks like the LOG(INFO) was dropped in this diff?
> 
> Vinod Kone wrote:
>     Yea dropped it because it gets printed in deactivate(Framework*). I forgot to remove
the LOG(INFO) when I refactored deactivate().

But since this is a pretty infrequent occasion, would it not be useful to know why we're deactivating
a framework? I used this old log line today to distinguish a driver triggered deactivation.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15773/#review29380
-----------------------------------------------------------


On Nov. 25, 2013, 7:46 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15773/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 7:46 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-834
>     https://issues.apache.org/jira/browse/MESOS-834
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See bug for details.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp c86c1f1e7eb23c168bcd2e8ab0a0701c421fc59d 
>   src/master/master.cpp a08d01208ff7bbb878b2d50d8406efee4de86171 
>   src/tests/fault_tolerance_tests.cpp 6cb5829119ed3e855740fb9331e4fb19c16d3629 
> 
> Diff: https://reviews.apache.org/r/15773/diff/
> 
> 
> Testing
> -------
> 
> make check (Linux and OSX)
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="*IgnoreKillTaskFromUnregisteredFramework*"
 --gtest_repeat=1000 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message