mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 15542: Offer an execvp like interface for running tasks.
Date Fri, 22 Nov 2013 22:16:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15542/#review29319
-----------------------------------------------------------

Ship it!


Would it make sense to follow up with a test (in src/tests) which exercises and validates
the new convention?


src/launcher/executor.cpp
<https://reviews.apache.org/r/15542/#comment56486>

    Can you wrap to 2 indents? So it becomes
    
    std::copy(
        command.arguments().begin(),
        command.arguments().end(),
        args.end());



src/launcher/executor.cpp
<https://reviews.apache.org/r/15542/#comment56487>

    A short comment on exec's char const requirement would be nice. This is the right way
but looks like a mistake when you skim it :)



src/launcher/executor.cpp
<https://reviews.apache.org/r/15542/#comment56488>

    Can you wrap in the same way as mentioned above?



src/launcher/launcher.cpp
<https://reviews.apache.org/r/15542/#comment56489>

    As mentioned above


- Niklas Nielsen


On Nov. 21, 2013, 6:51 p.m., Jason Dusek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15542/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, 6:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Offer an execvp like interface for running tasks.
> 
> Review: https://reviews.apache.org/r/15542
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 655f86757487ddbe551fdcf53eb793e773ecdd34 
>   src/examples/python/test_framework.py deca48e779ae099424fa73bb9a8ac5c419c5faf1 
>   src/launcher/executor.cpp b73ab479500a7347a38ba53acecfab9229f1080d 
>   src/launcher/launcher.cpp d5ab66704429a95eeb8eda5188e33d8e691221af 
>   src/launcher/main.cpp de64609905ee63096c0173fe7e64a1eafea5d6bf 
>   src/slave/process_isolator.cpp a6e9ed6a654972e8a51a9a033052e02ce44fe3e4 
> 
> Diff: https://reviews.apache.org/r/15542/diff/
> 
> 
> Testing
> -------
> 
> Ran Python test executor and `make check`.
> 
> 
> Thanks,
> 
> Jason Dusek
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message