mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brenden Matthews" <bren...@diddyinc.com>
Subject Re: Review Request 15745: Fixed some task reconciliation cases.
Date Fri, 22 Nov 2013 00:32:49 GMT


> On Nov. 21, 2013, 7:59 p.m., Niklas Nielsen wrote:
> > src/master/master.cpp, line 1597
> > <https://reviews.apache.org/r/15745/diff/2/?file=389363#file389363line1597>
> >
> >     What happens if status.task_id() does not exist in tasks? Is it silently ignored
or does it fail?
> 
> Brenden Matthews wrote:
>     In this case I'm assuming it has been set.  If not, it will just return an empty
value.

Err, that didn't even make sense.  The docs at http://www.boost.org/doc/libs/1_38_0/doc/html/boost/unordered_map.html
say it "erases all keys matching K", which means it does nothing in the case where the key
is not present.


- Brenden


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15745/#review29244
-----------------------------------------------------------


On Nov. 22, 2013, 12:30 a.m., Brenden Matthews wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15745/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2013, 12:30 a.m.)
> 
> 
> Review request for mesos and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Fixed some task reconciliation cases.
> 
> Case 1:
> 
> If a slave is known but the task cannot be found, we should assume that
> the task has been lost.  It's possible that the following events
> occurred:
> 
>  1) Framework disconnected from master
>  2) Master terminated framework's tasks
>  3) Framework reconnects to master, and (incorrectly) assumes tasks are
>  still running
> 
> Case 2:
> 
> If a framework loses track of running tasks, the master should inform
> the framework of which tasks it knows to be running, in addition to any
> which have had a state change.
> 
> Review: https://reviews.apache.org/r/15745
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp a08d01208ff7bbb878b2d50d8406efee4de86171 
> 
> Diff: https://reviews.apache.org/r/15745/diff/
> 
> 
> Testing
> -------
> 
> `make check` & tested in staging cluster.
> 
> 
> Thanks,
> 
> Brenden Matthews
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message