mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Review Request 15487: Fixed a bug where Group::cancel can return a failed future if the membership is already cancelled
Date Wed, 13 Nov 2013 18:14:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15487/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.


Bugs: MESOS-811
    https://issues.apache.org/jira/browse/MESOS-811


Repository: mesos-git


Description
-------

The API stipulates that a successful Future<bool> but with 'false' value should be returned.


This can happen when: 
1) The cancel() operation is queued up due to connectivity issue but then invoked again by
sync() the membership could be gone. 
2) Even if not delayed, in cancel() we first checked whether the membership exists in our
local cache but the membership could have expired by then (or when we invoke zk->remove(...))
but we have yet to receive the update for it.

This is part of the contender review chain.


Diffs
-----

  src/zookeeper/group.cpp cd58d230a2715b9ed01002443ebd7b5366d31be6 

Diff: https://reviews.apache.org/r/15487/diff/


Testing
-------

Tested in https://reviews.apache.org/r/13086/


Thanks,

Jiang Yan Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message