-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13086/#review28689
-----------------------------------------------------------
Ship it!
Looks good, the two things were:
1. Using .then on candidacy to withdraw when a caller calls withdraw() before achieving candidacy.
2. Let's think about what we do on discard operations, since we're not withdrawing maybe it's
better to do nothing like Group?
- Ben Mahler
On Nov. 5, 2013, 10:17 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13086/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 10:17 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-496
> https://issues.apache.org/jira/browse/MESOS-496
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/Makefile.am 9780d07a23ca196c541a44a85499c2f44a574b9c
> src/tests/zookeeper_test_server.cpp 0b22f319a53d08f9fe15c97c634b03358f40ba7e
> src/tests/zookeeper_tests.cpp 16c5fb7daaf684ece5542b42dd9e9ec66f4a41ce
> src/zookeeper/contender.hpp PRE-CREATION
> src/zookeeper/contender.cpp PRE-CREATION
> src/zookeeper/detector.hpp PRE-CREATION
> src/zookeeper/detector.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13086/diff/
>
>
> Testing
> -------
>
> make check 100 times.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
|