mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 15333: Added Owned<T>::share().
Date Fri, 08 Nov 2013 21:42:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15333/#review28578
-----------------------------------------------------------


Why did you move this into libprocess?

Can you split this change into separate reviews for libprocess / stout / mesos?

- Ben Mahler


On Nov. 8, 2013, 1:30 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15333/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2013, 1:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> Renamed to Shared<T>::upgrade to Shared<T>::own().
> 
> Also, moved owned.hpp to libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 47e8dbb 
>   3rdparty/libprocess/3rdparty/stout/include/stout/owned.hpp 3433f50 
>   3rdparty/libprocess/Makefile.am d348780 
>   3rdparty/libprocess/include/process/owned.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/shared.hpp e0c7991 
>   3rdparty/libprocess/include/process/statistics.hpp fbae641 
>   3rdparty/libprocess/src/tests/owned_tests.cpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/shared_tests.cpp 860a9aa 
>   3rdparty/libprocess/src/tests/statistics_tests.cpp 8695f45 
>   src/master/master.hpp e377af8 
>   src/master/master.cpp 8e14a07 
>   src/sched/sched.cpp 3abe72f 
>   src/slave/gc.hpp 083aa79 
>   src/slave/monitor.cpp 9cb6256 
>   src/slave/reaper.hpp 4498139 
>   src/slave/slave.hpp 68526f3 
>   src/tests/cluster.hpp bea395a 
> 
> Diff: https://reviews.apache.org/r/15333/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message