Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 826B710CD2 for ; Wed, 23 Oct 2013 18:56:44 +0000 (UTC) Received: (qmail 47696 invoked by uid 500); 23 Oct 2013 18:56:42 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 47631 invoked by uid 500); 23 Oct 2013 18:56:42 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 47614 invoked by uid 99); 23 Oct 2013 18:56:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Oct 2013 18:56:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F35731D3686; Wed, 23 Oct 2013 18:56:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7249961801256190356==" MIME-Version: 1.0 Subject: Re: Review Request 14616: Refactored slave recovery to make reading checkpointed data asynchronous. From: "Vinod Kone" To: "Benjamin Hindman" , "Ben Mahler" Cc: "mesos" , "Vinod Kone" Date: Wed, 23 Oct 2013 18:56:38 -0000 Message-ID: <20131023185638.3694.5100@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/14616/ X-Sender: "Vinod Kone" References: <20131017215521.7314.90151@reviews.apache.org> In-Reply-To: <20131017215521.7314.90151@reviews.apache.org> Reply-To: "Vinod Kone" --===============7249961801256190356== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14616/ ----------------------------------------------------------- (Updated Oct. 23, 2013, 6:56 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes ------- benm's. NNFR. Bugs: MESOS-732 https://issues.apache.org/jira/browse/MESOS-732 Repository: mesos-git Description ------- Improvements: --> Reading from disk is now done in a separate libprocess (process::async ftw :)) --> Streamlined recovery code. Diffs (updated) ----- src/slave/slave.hpp 22fb74b71a0f52d9d67b92ecc286fa8d350e41a4 src/slave/slave.cpp debb2f4ce05fbfec450197e68bc8a0c78f1d0adf src/slave/state.cpp 5208e4e8eaaea5aea9e23a6ac7d09822e15433b2 src/slave/status_update_manager.hpp 1f55f868548ae79052856e0255097b447ffe7573 src/slave/status_update_manager.cpp b6afeb18d3bd97ca4f4238b2ffbf6bd7de8e6888 src/tests/slave_recovery_tests.cpp 02dd25f3427562373d0396669c0f010e1dae67c6 Diff: https://reviews.apache.org/r/14616/diff/ Testing ------- make check Thanks, Vinod Kone --===============7249961801256190356==--