Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 89BF8102ED for ; Wed, 2 Oct 2013 05:46:08 +0000 (UTC) Received: (qmail 72184 invoked by uid 500); 2 Oct 2013 05:45:32 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 72087 invoked by uid 500); 2 Oct 2013 05:45:26 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 72071 invoked by uid 99); 2 Oct 2013 05:45:24 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Oct 2013 05:45:24 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 375631D33FC; Wed, 2 Oct 2013 05:45:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9151569626802604624==" MIME-Version: 1.0 Subject: Re: Review Request 14435: Fixed a bug with resource accounting in reconciliation. From: "Ben Mahler" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Wed, 02 Oct 2013 05:45:23 -0000 Message-ID: <20131002054523.28588.88503@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/14435/ X-Sender: "Ben Mahler" References: <20131002002514.28588.67896@reviews.apache.org> In-Reply-To: <20131002002514.28588.67896@reviews.apache.org> Reply-To: "Ben Mahler" --===============9151569626802604624== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14435/ ----------------------------------------------------------- (Updated Oct. 2, 2013, 5:45 a.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Changes ------- Vinod's review. Bugs: MESOS-711 https://issues.apache.org/jira/browse/MESOS-711 Repository: mesos-git Description ------- This adds the following two calls to the Allocator: slaveDisconnected(SlaveID) slaveReconnected(SlaveID) Which allows the allocator to maintain Slave state when checkpointing slaves disconnect. This is in contrast to the existing code which completely removes disconnected checkpointing slaves from the allocator and re-adds them upon reconnection. However, this is complex to get correct, and ultimately had bugs: MESOS-711. I've included a test in the subsequent change in this chain. Diffs (updated) ----- src/master/allocator.hpp 46a7370d589d939ca64d645879a09221b8491569 src/master/hierarchical_allocator_process.hpp 183b205663e82aa53bb3898cac0b1be10b9a4f3f src/master/master.cpp a49b17ef43fca5b385a89731ca8776a26b61399a src/tests/mesos.hpp 8fbd56c8dd438a08673b54630bfe25d60ad5ee0e Diff: https://reviews.apache.org/r/14435/diff/ Testing ------- make check Added a test in the subsequent review. Thanks, Ben Mahler --===============9151569626802604624==--