Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 222FD1063A for ; Tue, 1 Oct 2013 21:04:23 +0000 (UTC) Received: (qmail 27006 invoked by uid 500); 1 Oct 2013 21:04:21 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 26789 invoked by uid 500); 1 Oct 2013 21:04:18 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 26777 invoked by uid 99); 1 Oct 2013 21:04:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Oct 2013 21:04:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CD7D51D33EE; Tue, 1 Oct 2013 21:04:15 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6192999980061690824==" MIME-Version: 1.0 Subject: Review Request 14431: Fixed a bug with resource accounting during slave removal. From: "Ben Mahler" To: "Benjamin Hindman" , "Thomas Marshall" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Tue, 01 Oct 2013 21:04:15 -0000 Message-ID: <20131001210415.22177.64680@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/14431/ X-Sender: "Ben Mahler" Reply-To: "Ben Mahler" --===============6192999980061690824== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14431/ ----------------------------------------------------------- Review request for mesos, Benjamin Hindman, Thomas Marshall, and Vinod Kone. Bugs: MESOS-621 https://issues.apache.org/jira/browse/MESOS-621 Repository: mesos-git Description ------- I noticed this bug described in Thomas' comment in MESOS-621, so I figured I would fix it along the way to MESOS-711. The recovery of executor resources upon slave removal was missing. Diffs ----- src/master/master.cpp a49b17ef43fca5b385a89731ca8776a26b61399a src/tests/allocator_tests.cpp c57da6eb3c431b47468b6a6941c3de06af9209e5 Diff: https://reviews.apache.org/r/14431/diff/ Testing ------- make check and updated a test to reflect the change Thanks, Ben Mahler --===============6192999980061690824==--