Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 56BFCFEC1 for ; Tue, 1 Oct 2013 17:53:00 +0000 (UTC) Received: (qmail 78372 invoked by uid 500); 1 Oct 2013 17:52:59 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 78152 invoked by uid 500); 1 Oct 2013 17:52:59 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 78137 invoked by uid 99); 1 Oct 2013 17:52:58 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Oct 2013 17:52:58 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A020C1D33D5; Tue, 1 Oct 2013 17:52:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8600998405759775087==" MIME-Version: 1.0 Subject: Re: Review Request 14292: Added authentication support to scheduler and master. From: "Vinod Kone" To: "Benjamin Hindman" , "Ben Mahler" Cc: "mesos" , "Vinod Kone" Date: Tue, 01 Oct 2013 17:52:57 -0000 Message-ID: <20131001175257.28587.37720@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/14292/ X-Sender: "Vinod Kone" References: <20130930024701.28587.68132@reviews.apache.org> In-Reply-To: <20130930024701.28587.68132@reviews.apache.org> Reply-To: "Vinod Kone" --===============8600998405759775087== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14292/ ----------------------------------------------------------- (Updated Oct. 1, 2013, 5:52 p.m.) Review request for mesos, Benjamin Hindman and Ben Mahler. Changes ------- ben's comments. also updated example tests to do auth. I'm still investigating the flaky JavaFramework test (see Testing done) Bugs: MESOS-704 https://issues.apache.org/jira/browse/MESOS-704 Repository: mesos-git Description ------- Added authentication support for scheduler driver and master. Diffs (updated) ----- include/mesos/mesos.proto 957576bbc1c73513a9591194d017f76fe562a616 include/mesos/scheduler.hpp cf3ecdaaf40fd878a80fe0b6f7e61a0997329cbd src/Makefile.am ee336130ad93d8b524c841f75be36f00d4a2b147 src/common/type_utils.hpp 674a8820c339c6446dfa7d444457477ab4512e79 src/examples/java/TestExceptionFramework.java 8ea55408686d898b52d3809afe216462127e64d1 src/examples/java/TestFramework.java 687ed0d012ccbb20ecb6830e9e86527273361298 src/examples/long_lived_framework.cpp 08ccc75df13467a1e823d35afe69cd0dc521fcf3 src/examples/no_executor_framework.cpp 3ffbbb7ad8df308ea2f55b6543fbaaf7ec7f212b src/examples/python/test_framework.py eb2012735a075233850788b7e9d138a78447bae6 src/examples/test_framework.cpp 0065de16c00a964959d1fceb824c436c20e992ee src/java/jni/construct.cpp b01bd7ae2eda2dc5e0dcd68848c65bd9f9ea81f0 src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 6d2a03b6a88e71ac4e2e2d1ee8e15925e393ef3d src/java/src/org/apache/mesos/MesosSchedulerDriver.java 7ef1fe7755286bf92b94d7ece4f72d54e5b57a84 src/master/flags.hpp d59e67d5b2799d6d7a37e9cfe7246ae7372091ac src/master/master.hpp bd5cb1ff05967518d7dc7f3a9dc0d32c22eb9643 src/master/master.cpp a49b17ef43fca5b385a89731ca8776a26b61399a src/python/native/mesos_scheduler_driver_impl.cpp f25d41d38caf2701813dbec0d342a3b327e9dedf src/sasl/authenticator.hpp 2f78cf0fdd97f0ddc3a6ebd162e6559497d708e4 src/sched/sched.cpp c399f2481259683a8e178abb3478307042292f23 src/tests/allocator_tests.cpp c57da6eb3c431b47468b6a6941c3de06af9209e5 src/tests/allocator_zookeeper_tests.cpp 6e3214c15c14dc8ba82082738c172c8833cd0887 src/tests/authentication_tests.cpp PRE-CREATION src/tests/exception_tests.cpp 3fc1ac32d553644080a88f04f22077691ae1820b src/tests/fault_tolerance_tests.cpp 10e52c401476eb8416361de49b8e4061bb7ac4f3 src/tests/gc_tests.cpp e404de3bfacfcac5515995f1b45c3d39181e138f src/tests/isolator_tests.cpp cd3b3000060b379ef10e38a2a98a2eebe69d90fc src/tests/master_detector_tests.cpp 2d140ba1a364a7af4d643951d6016ac17dd10526 src/tests/master_tests.cpp 52f09d4f1ddeabcc1a797a13fae9641b72425dd5 src/tests/mesos.hpp 8fbd56c8dd438a08673b54630bfe25d60ad5ee0e src/tests/mesos.cpp 776cb0f13d10b4ae437fe9a3c97dc8b3481290af src/tests/resource_offers_tests.cpp 3888e461de5c8fa807cff2fd2bd7ca12c704823a src/tests/script.cpp e72eea63bf25cd75ed1c44714b281530605c7db3 src/tests/slave_recovery_tests.cpp 48b2e6380a9ae688291992f3bf25c3cc473bc808 src/tests/status_update_manager_tests.cpp cf420e4764356402f05b27c3b8e8802c21a58f8e Diff: https://reviews.apache.org/r/14292/diff/ Testing (updated) ------- OSX: make check ./bin/mesos-tests.sh --gtest_filter="*FaultTolerance*" --gtest_repeat=1000 --gtest_break_on_failure --gtest_shuffle Linux: make check GTEST_FILTER='' Couldn't run tests on linux because the boxes I've access to do not support SASL :/ It all compiles fwiw. All our tests do auth now. yay! JavaFramework test sometimes aborts! [ RUN ] ExamplesTest.JavaFramework ... ... ... I1001 10:48:33.198264 1712553984 sched.cpp:498] Scheduler::statusUpdate took 699us I1001 10:48:33.199173 1712553984 sched.cpp:601] Stopping framework '201310011048-1629165996-55418-82311-0000' I1001 10:48:33.199167 1712017408 hierarchical_allocator_process.hpp:598] Recovered cpus(*):1; mem(*):128 (total allocatable: cpus(*):4; mem(*):7168; disk(*):481998; ports(*):[31000-32000]) on slave 201310011048-1629165996-55418-82311-0 from framework 201310011048-1629165996-55418-82311-0000 I1001 10:48:33.199252 1712017408 slave.cpp:1899] Status update manager successfully handled status update TASK_FINISHED (UUID: 8664f9d0-6029-4733-bfae-e91842b7bf03) for task 4 of framework 201310011048-1629165996-55418-82311-0000 I1001 10:48:33.199278 1712017408 slave.cpp:1905] Sending acknowledgement for status update TASK_FINISHED (UUID: 8664f9d0-6029-4733-bfae-e91842b7bf03) for task 4 of framework 201310011048-1629165996-55418-82311-0000 to executor(1)@172.25.27.97:55419 I1001 10:48:33.199800 1711480832 status_update_manager.cpp:375] Received status update acknowledgement (UUID: 138b0335-6d7c-4bc3-9b60-b5209c4f669c) for task 3 of framework 201310011048-1629165996-55418-82311-0000 I1001 10:48:33.199880 1711480832 status_update_manager.cpp:502] Cleaning up status update stream for task 3 of framework 201310011048-1629165996-55418-82311-0000 I1001 10:48:33.200502 1710944256 master.cpp:921] Asked to unregister framework 201310011048-1629165996-55418-82311-0000 I1001 10:48:33.200548 1710944256 master.cpp:2211] Removing framework 201310011048-1629165996-55418-82311-0000 I1001 10:48:33.200547 1672138752 exec.cpp:331] Executor received status update acknowledgement 8664f9d0-6029-4733-bfae-e91842b7bf03 for task 4 of framework 201310011048-1629165996-55418-82311-0000 I1001 10:48:33.200618 1672675328 process.cpp:986] Socket closed while receiving I1001 10:48:34.823210 1666985984 process.cpp:986] Socket closed while receiving I1001 10:48:34.823551 1665912832 exec.cpp:440] Slave exited ... shutting down I1001 10:48:34.823717 1661644800 process.cpp:986] Socket closed while receiving I1001 10:48:34.823803 1672675328 process.cpp:986] Socket closed while receiving I1001 10:48:34.823884 1665376256 exec.cpp:76] Scheduling shutdown of the executor I1001 10:48:34.823931 1665912832 exec.cpp:457] Executor::shutdown took 217us I1001 10:48:34.824169 1671065600 exec.cpp:440] Slave exited ... shutting down I1001 10:48:34.824393 1672138752 exec.cpp:76] Scheduling shutdown of the executor I1001 10:48:34.824482 1659498496 exec.cpp:440] Slave exited ... shutting down ../../src/tests/script.cpp:80: Failure Failed java_framework_test.sh terminated with signal 'Abort trap: 6' Thanks, Vinod Kone --===============8600998405759775087==--