mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Dusek" <jason.du...@gmail.com>
Subject Re: Review Request 14963: implementation of CLI mesos-upload
Date Sat, 26 Oct 2013 21:15:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14963/#review27577
-----------------------------------------------------------



src/cli/mesos-upload
<https://reviews.apache.org/r/14963/#comment53515>

    It would be safer to pass the args as a sequence, thereby skipping over shell expansion
of the names.
    
      ["rsync", "-avz", self.src, self.host + "::" + self.dst]
    
    Indeed the, Popen docs tell us "...it is recommended to pass args as a sequence.".
      http://docs.python.org/2/library/subprocess.html#popen-constructor


- Jason Dusek


On Oct. 26, 2013, 1:26 a.m., Du Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14963/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2013, 1:26 a.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This commit implements a new CLI command mesos-upload, which upload specified local file(s)
to a specified directory on all slaves as defined in the var/mesos/deploy/slaves file. This
version is based on command "rsync". Its efficiency could be improved later when the number
of slaves goes large, e.g., by dynamically organize the slaves into a tree.
> 
> 
> Diffs
> -----
> 
>   src/cli/mesos-upload PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14963/diff/
> 
> 
> Testing
> -------
> 
> Need to be tested on a real cluster.
> 
> 
> Thanks,
> 
> Du Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message