mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 14940: Replace api.github.com for mark-down conversion.
Date Fri, 25 Oct 2013 21:24:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14940/#review27550
-----------------------------------------------------------

Ship it!


Sweet! Just two minor nits.


3rdparty/libprocess/include/process/help.hpp
<https://reviews.apache.org/r/14940/#comment53471>

    What's the convention around whitespace? From the code you're deleting it looks like this
should be:
    
    marked.setOptions({ breaks: true });



src/Makefile.am
<https://reviews.apache.org/r/14940/#comment53472>

    Can you align the '\'?


- Benjamin Hindman


On Oct. 25, 2013, 8:24 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14940/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2013, 8:24 p.m.)
> 
> 
> Review request for mesos and BenjaminVW BenjaminVW.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Using api.github.com for mark-down rendering limits off-line use and cause trouble with
help is excessively used on a shared IP due to api quota rules.
> 
> This patch includes Christopher Jeffrey's Marked mark-down compiler (https://github.com/chjj/marked)
and replaces the github api call.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/help.hpp 65b0590 
>   src/Makefile.am a2d8242 
>   src/webui/master/static/js/marked.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14940/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> And functional testing of /help endpoints.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message