mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 14662: Added os::utime() to update access/modification times.
Date Thu, 17 Oct 2013 18:37:13 GMT


> On Oct. 17, 2013, 2:48 a.m., Ben Mahler wrote:
> > No tests? ;)

i wrote and scrapped the test because it had to sleep for 1s (min granularity) to test mtime
changed.


> On Oct. 17, 2013, 2:48 a.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 229
> > <https://reviews.apache.org/r/14662/diff/1/?file=364984#file364984line229>
> >
> >     Looks like the return code is not needed, can you inline it?
> >     
> >     if (::utime(path.c_str(), NULL) == -1) {
> >       return ErrnoError();
> >     }
> >

done


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14662/#review27109
-----------------------------------------------------------


On Oct. 17, 2013, 6:37 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14662/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2013, 6:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Jie Yu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Needed for this for a subsequent review to do gc based on modtimes.
> 
> Also fixed 'touch()' to more closely resembled the touch utility.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 728122ec9eeb903723daa9294e258fed2141bea6

> 
> Diff: https://reviews.apache.org/r/14662/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message