mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 14292: Added authentication support to scheduler and master.
Date Thu, 10 Oct 2013 23:47:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14292/#review26909
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/14292/#comment52379>

    You could mention that this is because delay uses the pid() and if the master is stopped
/ started the pid remains the same, hence the dispatch on the new master.



src/master/master.cpp
<https://reviews.apache.org/r/14292/#comment52381>

    framework id might be useful in all of these log messages



src/master/master.cpp
<https://reviews.apache.org/r/14292/#comment52380>

    align the <<



src/master/master.cpp
<https://reviews.apache.org/r/14292/#comment52382>

    in-progress (since this is a compound adjective) :)



src/master/master.cpp
<https://reviews.apache.org/r/14292/#comment52383>

    authenticator(new sasl::Authenticator(from))



src/sched/sched.cpp
<https://reviews.apache.org/r/14292/#comment52384>

    authenticatee(new Authenticatee...);


- Ben Mahler


On Oct. 10, 2013, 10:26 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14292/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2013, 10:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, Joe Smith, Kevin Sweeney, Tobias
Weingartner, and Bill Farner.
> 
> 
> Bugs: MESOS-704
>     https://issues.apache.org/jira/browse/MESOS-704
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added authentication support for scheduler driver and master.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 957576bbc1c73513a9591194d017f76fe562a616 
>   include/mesos/scheduler.hpp cf3ecdaaf40fd878a80fe0b6f7e61a0997329cbd 
>   src/common/type_utils.hpp 674a8820c339c6446dfa7d444457477ab4512e79 
>   src/java/jni/construct.cpp b01bd7ae2eda2dc5e0dcd68848c65bd9f9ea81f0 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 6d2a03b6a88e71ac4e2e2d1ee8e15925e393ef3d

>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 7ef1fe7755286bf92b94d7ece4f72d54e5b57a84

>   src/master/flags.hpp d59e67d5b2799d6d7a37e9cfe7246ae7372091ac 
>   src/master/master.hpp bed051c6f82e07777a087b3632c8644f8e59f88a 
>   src/master/master.cpp 2fd48a6a3320ad8d3063bf3a31eda4e5f89bee35 
>   src/python/native/mesos_scheduler_driver_impl.cpp f25d41d38caf2701813dbec0d342a3b327e9dedf

>   src/sasl/authenticator.hpp 2f78cf0fdd97f0ddc3a6ebd162e6559497d708e4 
>   src/sched/sched.cpp c399f2481259683a8e178abb3478307042292f23 
> 
> Diff: https://reviews.apache.org/r/14292/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message