mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 14540: Task reconciliation for frameworks
Date Thu, 10 Oct 2013 23:05:54 GMT


> On Oct. 10, 2013, 10:26 p.m., Ben Mahler wrote:
> > src/common/protobuf_utils.hpp, line 66
> > <https://reviews.apache.org/r/14540/diff/6/?file=363468#file363468line66>
> >
> >     I think these should all be using CopyFrom (as you used elsewhere in this review),
feel free to change these here or leave as is to match the rest.
> 
> Niklas Nielsen wrote:
>     I am a bit puzzled that this still shows up. It should not be included in the latest
patch.

Ah - disregard that comment. This should be there :)


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14540/#review26901
-----------------------------------------------------------


On Oct. 10, 2013, 10:56 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14540/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2013, 10:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> A framework can reconcile tasks in connection with a master fail-over by sending it's
"last known state" of its tasks and confirm or reestablish the current state of the setup.
> If existing tasks have changed state, a status update with the new state will be sent.

> 
> Soon, we may be able to reliably tell if any slave or task is no longer present. A status
update with TASK_LOST should be sent to the framework.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 957576b 
>   include/mesos/scheduler.hpp cf3ecda 
>   src/common/protobuf_utils.hpp 5c5f052 
>   src/exec/exec.cpp d370560 
>   src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 6d2a03b 
>   src/java/src/org/apache/mesos/MesosSchedulerDriver.java 7ef1fe7 
>   src/java/src/org/apache/mesos/SchedulerDriver.java c806a55 
>   src/master/master.hpp bed051c 
>   src/master/master.cpp 2fd48a6 
>   src/messages/messages.proto c599eb2 
>   src/python/native/mesos_scheduler_driver_impl.hpp 83fdc18 
>   src/python/native/mesos_scheduler_driver_impl.cpp f25d41d 
>   src/sched/sched.cpp c399f24 
>   src/tests/master_tests.cpp 52f09d4 
> 
> Diff: https://reviews.apache.org/r/14540/diff/
> 
> 
> Testing
> -------
> 
> Tests has been provided in MasterTest.ReconcileTaskTest:
> 
> Test sends different state than current -> An update with the current state of task
should be received.
> Stubs have been left for future test, where test sends expected state of non-existing
task -> An update with TASK_LOST should be received.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message