mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 14548: Fixed a crash in the master during framework re-registration.
Date Wed, 09 Oct 2013 01:26:55 GMT


> On Oct. 9, 2013, 12:12 a.m., Vinod Kone wrote:
> > src/tests/fault_tolerance_tests.cpp, lines 1098-1110
> > <https://reviews.apache.org/r/14548/diff/1/?file=362469#file362469line1098>
> >
> >     Consider using LaunchTasks action. That would eliminate a lot of this boilerplate.

Ah, much nicer thanks!


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14548/#review26804
-----------------------------------------------------------


On Oct. 8, 2013, 11:53 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14548/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2013, 11:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-420
>     https://issues.apache.org/jira/browse/MESOS-420
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See MESOS-420 for more context. This removes a CHECK in the master and ensures the slave
does not send Tasks with executor id's when for command executors.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp cdfae1d46831c2de1fb535f60b38029fc1a0b9bb 
>   src/slave/slave.cpp 0ad457647dbc7870d478de2eab3a744f3b8704c5 
>   src/tests/fault_tolerance_tests.cpp 254eae4492a0047f1bdb26d9ba0c8ed66ef185b1 
> 
> Diff: https://reviews.apache.org/r/14548/diff/
> 
> 
> Testing
> -------
> 
> Added a test that fails without this patch.
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message