mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 14457: Added default constructor and ==, != operators for Result. (Stout)
Date Fri, 04 Oct 2013 18:08:43 GMT


> On Oct. 4, 2013, 5:45 p.m., Vinod Kone wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp, line 30
> > <https://reviews.apache.org/r/14457/diff/1/?file=360811#file360811line30>
> >
> >     Why did you need this?

Without it for "Result" class variables I need to manually default-initialize each of them
when NONE feels like a reasonable default. Any reason it should better not be added?


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14457/#review26677
-----------------------------------------------------------


On Oct. 3, 2013, 5:45 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14457/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2013, 5:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This is necessary for the master detector API: https://reviews.apache.org/r/13086/diff/#5
> Need to compare if the result passed in is the same as the stored value.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/result.hpp f918f86ed2eb74e021a4b851b311517f3313ad10

> 
> Diff: https://reviews.apache.org/r/14457/diff/
> 
> 
> Testing
> -------
> 
> Tested along with https://reviews.apache.org/r/13086/
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message