mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 14435: Fixed a bug with resource accounting in reconciliation.
Date Wed, 02 Oct 2013 18:57:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14435/
-----------------------------------------------------------

(Updated Oct. 2, 2013, 6:57 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Killed a stale comment.


Bugs: MESOS-711
    https://issues.apache.org/jira/browse/MESOS-711


Repository: mesos-git


Description
-------

This adds the following two calls to the Allocator:
  slaveDisconnected(SlaveID)
  slaveReconnected(SlaveID)

Which allows the allocator to maintain Slave state when checkpointing slaves disconnect. This
is in contrast to the existing code which completely removes disconnected checkpointing slaves
from the allocator and re-adds them upon reconnection. However, this is complex to get correct,
and ultimately had bugs: MESOS-711.

I've included a test in the subsequent change in this chain.


Diffs (updated)
-----

  src/master/allocator.hpp 46a7370d589d939ca64d645879a09221b8491569 
  src/master/hierarchical_allocator_process.hpp 183b205663e82aa53bb3898cac0b1be10b9a4f3f 
  src/master/master.cpp a49b17ef43fca5b385a89731ca8776a26b61399a 
  src/tests/mesos.hpp 8fbd56c8dd438a08673b54630bfe25d60ad5ee0e 

Diff: https://reviews.apache.org/r/14435/diff/


Testing
-------

make check

Added a test in the subsequent review.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message