mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 14436: Added a task reconciliation test.
Date Wed, 02 Oct 2013 05:45:37 GMT


> On Oct. 2, 2013, 1:05 a.m., Vinod Kone wrote:
> > src/tests/slave_recovery_tests.cpp, line 1855
> > <https://reviews.apache.org/r/14436/diff/1/?file=360252#file360252line1855>
> >
> >     s/executor//
> >     
> >     All of our slave recovery tests, including this, use command executor which
doesn't  have any resources :(

Done, added a TODO for using an explicit executor here.


> On Oct. 2, 2013, 1:05 a.m., Vinod Kone wrote:
> > src/tests/slave_recovery_tests.cpp, lines 1982-1985
> > <https://reviews.apache.org/r/14436/diff/1/?file=360252#file360252line1982>
> >
> >     Kill?

Thanks!


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14436/#review26587
-----------------------------------------------------------


On Oct. 2, 2013, 12:27 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14436/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2013, 12:27 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-711
>     https://issues.apache.org/jira/browse/MESOS-711
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This adds a test for https://reviews.apache.org/r/14435/
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 48b2e6380a9ae688291992f3bf25c3cc473bc808 
> 
> Diff: https://reviews.apache.org/r/14436/diff/
> 
> 
> Testing
> -------
> 
> make check and ran with 1400 iterations.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message