mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 14400: Implemented HostPort.
Date Tue, 01 Oct 2013 16:49:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14400/#review26565
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/include/process/hostport.hpp
<https://reviews.apache.org/r/14400/#comment51802>

    I like the idea of making this explicit too.



3rdparty/libprocess/include/process/hostport.hpp
<https://reviews.apache.org/r/14400/#comment51803>

    s/that/pid/



3rdparty/libprocess/include/process/hostport.hpp
<https://reviews.apache.org/r/14400/#comment51804>

    Please use braces.



3rdparty/libprocess/include/process/hostport.hpp
<https://reviews.apache.org/r/14400/#comment51806>

    Braces please (even though I imagine you copied this from another place).



3rdparty/libprocess/include/process/hostport.hpp
<https://reviews.apache.org/r/14400/#comment51808>

    We should probably pull all this into a helper, perhaps add a TODO?



3rdparty/libprocess/include/process/hostport.hpp
<https://reviews.apache.org/r/14400/#comment51807>

    You can kill these newlines.


- Benjamin Hindman


On Sept. 30, 2013, 2:45 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14400/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2013, 2:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am 130d40c3301bc6ffa6d8e531e48d8d9406a61cf7 
>   3rdparty/libprocess/include/process/hostport.hpp PRE-CREATION 
>   3rdparty/libprocess/src/tests/hostport_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14400/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message