Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72A35106C8 for ; Mon, 23 Sep 2013 20:20:40 +0000 (UTC) Received: (qmail 6197 invoked by uid 500); 23 Sep 2013 20:20:40 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 5983 invoked by uid 500); 23 Sep 2013 20:20:39 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 5975 invoked by uid 500); 23 Sep 2013 20:20:39 -0000 Delivered-To: apmail-incubator-mesos-dev@incubator.apache.org Received: (qmail 5968 invoked by uid 99); 23 Sep 2013 20:20:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Sep 2013 20:20:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4ACC81D2EE2; Mon, 23 Sep 2013 20:20:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6379589852129689059==" MIME-Version: 1.0 Subject: Review Request 14288: stout: cleanup strings tokenize termination condition From: "David Mackey" To: "Benjamin Hindman" , "Ben Mahler" , "Vinod Kone" Cc: "David Mackey" , "mesos" Date: Mon, 23 Sep 2013 20:20:39 -0000 Message-ID: <20130923202039.1161.46327@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "David Mackey" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/14288/ X-Sender: "David Mackey" Reply-To: "David Mackey" --===============6379589852129689059== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14288/ ----------------------------------------------------------- Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Repository: mesos-git Description ------- Trivial cleanup of Stout's tokenize function. Also, this is last change I needed to get Clang Static Analyzer to build and analyze Mesos on Ubuntu 13.04. (It was complaining about offset never being read after offset = s.length();). Diffs ----- 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp ed14106 Diff: https://reviews.apache.org/r/14288/diff/ Testing ------- Thanks, David Mackey --===============6379589852129689059==--