mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Hindman <b...@berkeley.edu>
Subject Re: Review Request 14310: Added SASL authentication support.
Date Thu, 26 Sep 2013 00:27:43 GMT
If a function was declared virtual I try and define "overrides" of that
function as virtual as well. Since the parent of AuthenticateeProcess
declared it's destructor virtual I declared the destructor of
AuthenticateeProcess as virtual as well. Make sense?


On Wed, Sep 25, 2013 at 4:13 PM, Vinod Kone <vinodkone@gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14310/
>
> On September 25th, 2013, 5:32 p.m. UTC, *Vinod Kone* wrote:
>
>   src/sasl/authenticatee.hpp<https://reviews.apache.org/r/14310/diff/3/?file=356658#file356658line81>
(Diff
> revision 3)
>
> 81
>
>   virtual ~AuthenticateeProcess()
>
>   Why virtual?
>
>  On September 25th, 2013, 11 p.m. UTC, *Benjamin Hindman* wrote:
>
> http://stackoverflow.com/questions/461203/when-to-use-virtual-destructors
>
>  i meant "are we expecting this class to be subclassed?". Do we defensively declare all
our destructors virtual in our code base?
>
>
> - Vinod
>
> On September 24th, 2013, 8:26 p.m. UTC, Benjamin Hindman wrote:
>   Review request for mesos, Ben Mahler and Vinod Kone.
> By Benjamin Hindman.
>
> *Updated Sept. 24, 2013, 8:26 p.m.*
>  *Repository: * mesos-git
> Description
>
> Initial SASL based authentication support. (I'll likely also be cleaning some stuff up
as I deal with compilation issues with different libsasl2* versions.)
>
>   Testing
>
> make check
>
>   Diffs
>
>    - configure.ac (96ac7a81311e9f3765bd54e078368566a3cc33ca)
>    - include/mesos/mesos.proto (8f845cc9b7cd491622cb29a69f6909170510a664)
>    - src/Makefile.am (3eae9642b639e78f101e7fe580aa803beadbebda)
>    - src/messages/messages.proto
>    (4d400c2d8f6ecb9f7cf8635b2a98341206bbb6c5)
>    - src/sasl/authenticatee.hpp (PRE-CREATION)
>    - src/sasl/authenticator.hpp (PRE-CREATION)
>    - src/sasl/auxprop.hpp (PRE-CREATION)
>    - src/sasl/auxprop.cpp (PRE-CREATION)
>    - src/tests/sasl_tests.cpp (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/14310/diff/>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message