mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chi Zhang" <chzhc...@gmail.com>
Subject Review Request 14414: Set resource requirements in new ExecutorInfos from TaskInfo messages
Date Mon, 30 Sep 2013 21:12:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14414/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, David Mackey,
Vinod Kone, and Jiang Yan Xu.


Repository: mesos-git


Description
-------

    slave: Copy resource requirements from the first TaskInfo message to the 
    ExecutorInfo before an executor is launched.
                             
    Otherwise, this leads to a null value passed to launchExecutor for the     
    resources field. It's necessary for some resource subsystems to initialize 
    executors with resource requirement upfront.


Diffs
-----

  src/slave/slave.cpp 0ad4576 

Diff: https://reviews.apache.org/r/14414/diff/


Testing
-------

Can't tell for sure. With or without the patch, `make -j check` fails at the same place on
a Mesos dev box.

[----------] Global test environment tear-down                 
[==========] 263 tests from 47 test cases ran. (146351 ms total)               
[  PASSED  ] 259 tests.                                                       
[  FAILED  ] 4 tests, listed below:                                           
[  FAILED  ] CgroupsIsolatorTest.ROOT_CGROUPS_BalloonFramework                
[  FAILED  ] SASL.success                                                     
[  FAILED  ] SASL.failed1                                                      
[  FAILED  ] SASL.failed2                                                      
                                                                               
 4 FAILED TESTS                                                              
make[3]: *** [check-local] Error 1                                           
make[3]: Leaving directory `/home/czhang/mesos-apache/build/src'             
make[2]: *** [check-am] Error 2                                               
make[2]: Leaving directory `/home/czhang/mesos-apache/build/src'             
make[1]: *** [check] Error 2                                                 
make[1]: Leaving directory `/home/czhang/mesos-apache/build/src'             
make: *** [check-recursive] Error 1                                          
Connection to smfd-aki-27-sr1.devel.twitter.com closed.


Thanks,

Chi Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message