mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ross Allen" <ross...@mesosphe.re>
Subject Re: Review Request 14328: Aligned column headers to top for consistent rendering.
Date Wed, 25 Sep 2013 03:48:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14328/
-----------------------------------------------------------

(Updated Sept. 25, 2013, 3:48 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-702
    https://issues.apache.org/jira/browse/MESOS-702


Repository: mesos-git


Description
-------

Aligned column headers to top for consistent rendering.

"vertical-align: bottom;", which is Bootstrap's default for <th>
elements, renders inconsistently when the cell contains enough content
to wrap.

Nuking the style lets ".table th, .table td" win with
"vertical-align: top;" and renders consistently.


Diffs
-----

  src/webui/master/static/css/bootstrap-2.3.2.min.css b6428e695860151f82076e87810fe2d133339c2a


Diff: https://reviews.apache.org/r/14328/diff/


Testing
-------

Rendered home.html in Chrome and in Firefox, shrank window small enough for content to wrap,
and confirmed "vertical-align: top;" rendered consistently.


File Attachments (updated)
----------------

Before style change
  https://reviews.apache.org/media/uploaded/files/2013/09/25/before.png
After style change
  https://reviews.apache.org/media/uploaded/files/2013/09/25/after.png


Thanks,

Ross Allen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message