mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 13956: Fixed a CHECK failure in the master when successive exited events occur for a disconnected slave.
Date Wed, 04 Sep 2013 05:59:02 GMT


> On Sept. 4, 2013, 4:35 a.m., Vinod Kone wrote:
> > src/master/master.cpp, line 605
> > <https://reviews.apache.org/r/13956/diff/1/?file=347611#file347611line605>
> >
> >     s/slave/checkpointing slave/

Done, we should do a cleanup once we make checkpointing the default :)


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13956/#review25877
-----------------------------------------------------------


On Sept. 4, 2013, 5:58 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13956/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2013, 5:58 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-675
>     https://issues.apache.org/jira/browse/MESOS-675
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Rather than change the semantics of linking the re-registering slaves, I went with a
simpler fix of ignoring the duplicate exited events.
> 
> This is because there would need to be added checks to ensure the slave pid is not changing.
If it is changing, we will still need to re-link!
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 874d7fac42d3e948cd0f90d735873120bc75cb54 
> 
> Diff: https://reviews.apache.org/r/13956/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message