Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B24A510961 for ; Wed, 7 Aug 2013 22:00:27 +0000 (UTC) Received: (qmail 41513 invoked by uid 500); 7 Aug 2013 22:00:27 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 41479 invoked by uid 500); 7 Aug 2013 22:00:27 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 41471 invoked by uid 500); 7 Aug 2013 22:00:27 -0000 Delivered-To: apmail-incubator-mesos-dev@incubator.apache.org Received: (qmail 41464 invoked by uid 99); 7 Aug 2013 22:00:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Aug 2013 22:00:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8823C1D2650; Wed, 7 Aug 2013 22:00:25 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6832601159877646465==" MIME-Version: 1.0 Subject: Re: Review Request 13387: (Stout) Rewrote os::read(string path) because the existing implementation does not work well under the inconsistency of /proc pseudo filesystem. From: "Benjamin Hindman" To: "Benjamin Hindman" , "Ben Mahler" , "Vinod Kone" Cc: "Jiang Yan Xu" , "mesos" Date: Wed, 07 Aug 2013 22:00:25 -0000 Message-ID: <20130807220025.17556.92338@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/13387/ X-Sender: "Benjamin Hindman" References: <20130807212503.17559.5642@reviews.apache.org> In-Reply-To: <20130807212503.17559.5642@reviews.apache.org> Reply-To: "Benjamin Hindman" --===============6832601159877646465== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13387/#review24834 ----------------------------------------------------------- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp Add a newline please. 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp s/fp/file/ 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp s/len/length/ 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp Please document these semantics, in particular, focus on the malloc and realloc that will occur for 'line' given 'length'. 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp Let's move free(line) just below the while and put a newline after it. 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp s/err/error/ 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp s/;;/;/ - Benjamin Hindman On Aug. 7, 2013, 9:25 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13387/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2013, 9:25 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-534 > https://issues.apache.org/jira/browse/MESOS-534 > > > Repository: mesos-git > > > Description > ------- > > - Removed os::read(int fd) because it's not used elsewhere. > - Separated os::read()s into os/read.hpp. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am 770378d11d30e1e222e418c1839affd9d4ffe8d3 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 448739e313bf5127e7e5469dd4090445dc5c5405 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/13387/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > > --===============6832601159877646465==--