Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DABB010EA9 for ; Thu, 1 Aug 2013 19:24:16 +0000 (UTC) Received: (qmail 90969 invoked by uid 500); 1 Aug 2013 19:24:16 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 90944 invoked by uid 500); 1 Aug 2013 19:24:16 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 90936 invoked by uid 500); 1 Aug 2013 19:24:16 -0000 Delivered-To: apmail-incubator-mesos-dev@incubator.apache.org Received: (qmail 90931 invoked by uid 99); 1 Aug 2013 19:24:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Aug 2013 19:24:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A15811D15E3; Thu, 1 Aug 2013 19:24:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3047364690438614262==" MIME-Version: 1.0 Subject: Re: Review Request 13006: Link to executor sandbox from framework template From: "Benjamin Hindman" To: "Benjamin Hindman" Cc: "Ross Allen" , "mesos" Date: Thu, 01 Aug 2013 19:24:14 -0000 Message-ID: <20130801192414.6985.29484@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/13006/ X-Sender: "Benjamin Hindman" References: <20130801042419.6985.83462@reviews.apache.org> In-Reply-To: <20130801042419.6985.83462@reviews.apache.org> Reply-To: "Benjamin Hindman" --===============3047364690438614262== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13006/#review24464 ----------------------------------------------------------- Ship it! LESS CLICKS! ;) - Benjamin Hindman On Aug. 1, 2013, 4:24 a.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13006/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2013, 4:24 a.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos-git > > > Description > ------- > > Link to executor sandbox from framework template > > The framework page is rendered with info from the master, but the > sandbox directory is known only by the slave. To link to the directory > from a page rendered by the master, create a page in between that acts > as a redirector by first asking for the directory from the slave. > > If the sandbox is important for linking, the master could return > `executor.directory` in the `state.json` endpoint and negate the need > for this redirection stuff. > > Review: http://reviews.apache.org/r/13006 > > > Diffs > ----- > > src/webui/master/static/framework.html 0cedb393455e6c858db69cf088b1a5cef7426f82 > src/webui/master/static/js/app.js d59e22c6f6debad757b415d5bf81cc34fcfee8e9 > src/webui/master/static/js/controllers.js c553e358e9f7598033e55a2e8dfff167d8282f7b > src/webui/master/static/slave_executor.html 1e43aff172457e39a28e6a6fa13c03efc9f9f1fd > src/webui/master/static/slave_framework.html 63eb5c4e85ad281ed6c348ac8cad9bc60534186b > > Diff: https://reviews.apache.org/r/13006/diff/ > > > Testing > ------- > > * Navigated to sandbox from framework page > * Visited redirect link with bad framework and bad executor ID to ensure it redirected back properly > > > Thanks, > > Ross Allen > > --===============3047364690438614262==--