mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 13699: Added a re-registration time for slaves, and fixed an issue with Framework::reregisteredTime.
Date Thu, 22 Aug 2013 03:19:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13699/#review25391
-----------------------------------------------------------

Ship it!



src/master/master.hpp
<https://reviews.apache.org/r/13699/#comment49806>

    Can you add a TODO here that we should be ideally passing a UUID here to distinguish.
IIUC, we are/were using last registered time as a hack. 



src/master/master.cpp
<https://reviews.apache.org/r/13699/#comment49807>

    Not sure if you want to do this in this review, but can you add a comment on why use pids
in deactivatedSlaves instead of ids. Probably in the header file.



src/master/master.cpp
<https://reviews.apache.org/r/13699/#comment49808>

    Can you expand on this comment?


- Vinod Kone


On Aug. 22, 2013, 1:34 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13699/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2013, 1:34 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-651
>     https://issues.apache.org/jira/browse/MESOS-651
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> With slave recovery, this proves useful for seeing when slaves have re-registered with
the master.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 1ac84a9f75df43632ddbd1fec50333c159651f15 
>   src/master/master.hpp 30752d2698931624fdf4aa6e40ef9fc4ec58dc6d 
>   src/master/master.cpp d53b8bb97da45834790cca6e04b70b969a8d3453 
>   src/webui/master/static/slaves.html 15877b7069a11b9feda58be313620f94624a62ea 
> 
> Diff: https://reviews.apache.org/r/13699/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> manual runs with a master (local + zk) and rolling slaves / master.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message