mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ross Allen" <ross...@mesosphe.re>
Subject Re: Review Request 13606: Added a Top abstraction to the webui.
Date Fri, 16 Aug 2013 18:54:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13606/#review25244
-----------------------------------------------------------



src/webui/master/static/js/controllers.js
<https://reviews.apache.org/r/13606/#comment49545>

    Can this be moved to a Statistics object to prevent duplicating this structure below for
each slave? On instantiation it can initialize each of these values on itself.



src/webui/master/static/js/controllers.js
<https://reviews.apache.org/r/13606/#comment49540>

    These `if (!$scope.monitor)` blocks can be handled in the Top service.



src/webui/master/static/slave.html
<https://reviews.apache.org/r/13606/#comment49541>

    Can something like `cpus_total_usage` be added to the statistics object so addition is
kept out of the template?



src/webui/master/static/slave.html
<https://reviews.apache.org/r/13606/#comment49543>

    This division should be moved to the statistics object as well.


- Ross Allen


On Aug. 15, 2013, 10:14 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13606/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2013, 10:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ross Allen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This adds a Top abstraction to the webui for periodically polling the monitoring endpoint.
> 
> Instead of having each controller have to deal with monitoring information during the
update cycle, this allows each controller to setup asynchronous monitoring updates, stopping
it when the controller becomes inactive.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js 305aeaa195183c188e8ed949ccd67b49cbd757a0

>   src/webui/master/static/slave.html e1dabc0b04dec404a0aabd52d0387a0af70ad40d 
>   src/webui/master/static/slave_executor.html 519847c0de077717c88c4d35804ad40d339d4246

>   src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb

> 
> Diff: https://reviews.apache.org/r/13606/diff/
> 
> 
> Testing
> -------
> 
> Ran the long-lived-framework.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message