mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Review Request 13604: Refactored the ResourceMonitor to use TimeSeries directly instead of Statistics.
Date Thu, 15 Aug 2013 22:14:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13604/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Bugs: MESOS-375
    https://issues.apache.org/jira/browse/MESOS-375


Repository: mesos-git


Description
-------

Dumping data into Statistics leads to high memory consumption for various reasons. We had
to encode the string values of the statistical information into a unique string key ("frameworkId/ExecutorId/statistic_name"),
all of these combinations consume a lot of memory. This also made it clunky in terms of retrieving
the latest information. This now uses TimeSeries<ResourceStatistics> to efficiently
store the monitoring information.

My subsequent change in this chain of reviews returns immediate values to simplify the statistics.json
endpoint.

This also uses JSON::Protobuf I recently added to simplify the JSON generation substantially!


Diffs
-----

  src/slave/monitor.hpp 52568ad8ec566f7cf36c249c76d798d44eacb578 
  src/slave/monitor.cpp 8e1eb353c55f9a04b07c382c10c669715a2d7ac2 
  src/tests/monitor_tests.cpp 31424160b0493ef37705be25cd97f74e027d85ef 

Diff: https://reviews.apache.org/r/13604/diff/


Testing
-------

make check (no test modifications needed for this change as it preserves the API)


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message