mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 13487: Fixed slave to not re-register with Command Executors.
Date Tue, 13 Aug 2013 00:52:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13487/#review25046
-----------------------------------------------------------

Ship it!



src/slave/slave.cpp
<https://reviews.apache.org/r/13487/#comment49200>

    s/master/the master/



src/slave/slave.cpp
<https://reviews.apache.org/r/13487/#comment49201>

    doesn't know about them as in?
    
    How about:
    
    "because the master does not store command executors; they are generated by the slave."



src/slave/slave.cpp
<https://reviews.apache.org/r/13487/#comment49202>

    s/master/the master/
    
    ditto for a more precise comment


- Ben Mahler


On Aug. 13, 2013, 12:46 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13487/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2013, 12:46 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-638
>     https://issues.apache.org/jira/browse/MESOS-638
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 8ba605bafae36e0418969ba9cea51dd0cd7e91db 
>   src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac 
> 
> Diff: https://reviews.apache.org/r/13487/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message