-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13387/#review24834
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp
<https://reviews.apache.org/r/13387/#comment48988>
Add a newline please.
3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp
<https://reviews.apache.org/r/13387/#comment48990>
s/fp/file/
3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp
<https://reviews.apache.org/r/13387/#comment48989>
s/len/length/
3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp
<https://reviews.apache.org/r/13387/#comment48991>
Please document these semantics, in particular, focus on the malloc and realloc that will
occur for 'line' given 'length'.
3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp
<https://reviews.apache.org/r/13387/#comment48992>
Let's move free(line) just below the while and put a newline after it.
3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp
<https://reviews.apache.org/r/13387/#comment48993>
s/err/error/
3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp
<https://reviews.apache.org/r/13387/#comment48994>
s/;;/;/
- Benjamin Hindman
On Aug. 7, 2013, 9:25 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13387/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2013, 9:25 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-534
> https://issues.apache.org/jira/browse/MESOS-534
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> - Removed os::read(int fd) because it's not used elsewhere.
> - Separated os::read()s into os/read.hpp.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 770378d11d30e1e222e418c1839affd9d4ffe8d3
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 448739e313bf5127e7e5469dd4090445dc5c5405
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13387/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
|