mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 13261: Clarified the guidance for users when slave recovery fails.
Date Tue, 06 Aug 2013 17:52:42 GMT


> On Aug. 5, 2013, 6:56 p.m., Ben Mahler wrote:
> > src/slave/slave.cpp, line 398
> > <https://reviews.apache.org/r/13261/diff/1/?file=336047#file336047line398>
> >
> >     s/f/rf/?

it's a symlink.


> On Aug. 5, 2013, 6:56 p.m., Ben Mahler wrote:
> > src/slave/slave.cpp, lines 2563-2565
> > <https://reviews.apache.org/r/13261/diff/1/?file=336047#file336047line2563>
> >
> >     Even with --strict, they can just rm -rf the latest slave path, so it seems
like 'Restart the slave...' is an additional option when --strict is on.
> >     
> >     s/rm/rm -rf/ ?

I would like users to try --no-strict first before they go down the path of no recovery, because
--no-strict recovers as much as possible and tries to do the right thing imo.


> On Aug. 5, 2013, 6:56 p.m., Ben Mahler wrote:
> > src/slave/slave.cpp, line 396
> > <https://reviews.apache.org/r/13261/diff/1/?file=336047#file336047line396>
> >
> >     What does discarded mean in this case? Is it still a failure to recover? Perhaps
it needs a separate message that the recovery process was terminated, or?

discarded happens if isolator/status update manager discards recover() for whatever reason.
not sure if we want a separate message, because we still want them to take the same action.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13261/#review24666
-----------------------------------------------------------


On Aug. 3, 2013, 9:35 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13261/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2013, 9:35 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Brenden Matthews.
> 
> 
> Bugs: MESOS-613
>     https://issues.apache.org/jira/browse/MESOS-613
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp 7f6e6b456890db438092f19a22e4dd816bb33d04 
> 
> Diff: https://reviews.apache.org/r/13261/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message