mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 13196: Improved StatusUpdateManager's API by flattening the return types.
Date Sat, 03 Aug 2013 20:16:33 GMT


> On Aug. 1, 2013, 10:02 p.m., Benjamin Hindman wrote:
> > src/slave/slave.cpp, line 1351
> > <https://reviews.apache.org/r/13196/diff/1/?file=333302#file333302line1351>
> >
> >     FATAL to ERROR? How about a comment explaining why this is okay?

reverted back to FATAL. this was an oversight.


> On Aug. 1, 2013, 10:02 p.m., Benjamin Hindman wrote:
> > src/slave/slave.cpp, line 1817
> > <https://reviews.apache.org/r/13196/diff/1/?file=333302#file333302line1817>
> >
> >     Likewise here ...

added a comment. basically duplicate acks return failed future, so its not fatal.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13196/#review24480
-----------------------------------------------------------


On Aug. 1, 2013, 9:49 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13196/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2013, 9:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 97f2083db0dec2c1c9415f65d9bf8a834653bd18 
>   src/slave/slave.cpp 7f6e6b456890db438092f19a22e4dd816bb33d04 
>   src/slave/status_update_manager.hpp 795e74c2b88a071eb7ba720118e06077b6e41238 
>   src/slave/status_update_manager.cpp 9e9e4e2a47a609d65ed69a57de595852144a86c8 
> 
> Diff: https://reviews.apache.org/r/13196/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message