Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 10E3E10176 for ; Tue, 30 Jul 2013 18:29:46 +0000 (UTC) Received: (qmail 37890 invoked by uid 500); 30 Jul 2013 18:29:45 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 37580 invoked by uid 500); 30 Jul 2013 18:29:45 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 37355 invoked by uid 500); 30 Jul 2013 18:29:45 -0000 Delivered-To: apmail-incubator-mesos-dev@incubator.apache.org Received: (qmail 37186 invoked by uid 99); 30 Jul 2013 18:29:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Jul 2013 18:29:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 3793A1D033E; Tue, 30 Jul 2013 18:29:43 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5727930325000916542==" MIME-Version: 1.0 Subject: Re: Review Request 13049: Added /health endpoints to the Master and Slave. From: "Benjamin Hindman" To: "Benjamin Hindman" , "Vinod Kone" Cc: "Ben Mahler" , "mesos" Date: Tue, 30 Jul 2013 18:29:42 -0000 Message-ID: <20130730182942.3449.87282@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/13049/ X-Sender: "Benjamin Hindman" References: <20130730182627.3449.75293@reviews.apache.org> In-Reply-To: <20130730182627.3449.75293@reviews.apache.org> Reply-To: "Benjamin Hindman" --===============5727930325000916542== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13049/#review24259 ----------------------------------------------------------- Ship it! Ship It! - Benjamin Hindman On July 30, 2013, 6:26 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13049/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 6:26 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-585 > https://issues.apache.org/jira/browse/MESOS-585 > > > Repository: mesos-git > > > Description > ------- > > See MESOS-585. An explicit /health endpoint is useful as existing users tend to use /stats.json or /vars for health checking. > > > Diffs > ----- > > src/master/http.cpp a114462e15bc61da3178dba6bf40d32b4b7b55fa > src/master/master.hpp bdaf4d64c0ecdaf4539b9d13b2e3751f5731c0aa > src/master/master.cpp e4507acd97ebaf2ce693ec7343e9a4a563f6ff80 > src/slave/http.cpp b7d1582969e836eb040dd98e28a05b2f6044c8d3 > src/slave/slave.hpp 5a0fdd92529e85fbea2a3591b2c731182b736404 > src/slave/slave.cpp 54eaf8f5db47ff481b0590d214746cec63581680 > > Diff: https://reviews.apache.org/r/13049/diff/ > > > Testing > ------- > > make check and curl > > > Thanks, > > Ben Mahler > > --===============5727930325000916542==--