Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4AA7C104F3 for ; Tue, 23 Jul 2013 20:54:40 +0000 (UTC) Received: (qmail 37594 invoked by uid 500); 23 Jul 2013 20:54:40 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 37527 invoked by uid 500); 23 Jul 2013 20:54:40 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 37519 invoked by uid 500); 23 Jul 2013 20:54:40 -0000 Delivered-To: apmail-incubator-mesos-dev@incubator.apache.org Received: (qmail 37514 invoked by uid 99); 23 Jul 2013 20:54:40 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jul 2013 20:54:40 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F21621D015E; Tue, 23 Jul 2013 20:54:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5568530042929352084==" MIME-Version: 1.0 Subject: Review Request 12880: Compute framework stats in one iteration From: "Ross Allen" To: "Ross Allen" , "mesos" Date: Tue, 23 Jul 2013 20:54:38 -0000 Message-ID: <20130723205438.4988.95149@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ross Allen" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/12880/ X-Sender: "Ross Allen" Reply-To: "Ross Allen" --===============5568530042929352084== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12880/ ----------------------------------------------------------- Review request for mesos. Repository: mesos-git Description ------- Compute framework stats in one iteration Rather than iterate over 'frameworks' and 'completed_frameworks' once to update the slave mappings and a second time to calculate stats for the frameworks, move that work into a single loop. This also removes a 'concat' call that was creating a temporary Array used to calculate stats once and then thrown away. Diffs ----- src/webui/master/static/js/controllers.js dae12b61001ff0c7379169242e5d125ef6ca141b Diff: https://reviews.apache.org/r/12880/diff/ Testing ------- Rendered /slaves/:id to verify framework stats were still calculated properly. Thanks, Ross Allen --===============5568530042929352084==--