mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 13177: Updated the launcher to redirect stderr/stdout during forked setup.
Date Wed, 31 Jul 2013 23:52:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13177/#review24388
-----------------------------------------------------------

Ship it!


If you don't mind, want to kill 'local' from both CgroupsIsolator and ProcessIsolotor all
together?

- Benjamin Hindman


On July 31, 2013, 11:50 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13177/
> -----------------------------------------------------------
> 
> (Updated July 31, 2013, 11:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-599
>     https://issues.apache.org/jira/browse/MESOS-599
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> When the launcher fails there isn't any stderr/stdout created for the executor/task so
you're forced to look at the slave logs.
> 
> This makes it easier for framework developers to investigate launcher failures.
> 
> Also, note that I removed the ability to conditionally redirect IO, since this was being
used for local runs. I don't see why local runs would need to bypass the redirection, any
context I'm missing?
> 
> 
> Diffs
> -----
> 
>   src/launcher/launcher.hpp 637c9bcdfd9c3ee4c071cc46ba8fd274a06873cf 
>   src/launcher/launcher.cpp c7d2c302498f039836dff85efa9b696ae5663900 
>   src/launcher/main.cpp 5674afb7eeded167af97a953d174f4045860a4c8 
>   src/slave/cgroups_isolator.cpp 0faf7d50d76887cad02267ab11827664a4b63476 
>   src/slave/process_isolator.cpp cd794f6cb301a8c00a4c0ef906f95e53959ed905 
> 
> Diff: https://reviews.apache.org/r/13177/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message