mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 13028: Changed the SIGTERM handler to not dump a stacktrace.
Date Mon, 29 Jul 2013 20:37:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13028/
-----------------------------------------------------------

(Updated July 29, 2013, 8:37 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Benh feedback. Added a comment.


Repository: mesos-git


Description
-------

Users tend to associate a stacktrace with a crash. SIGTERM is termination due to user request.


Diffs (updated)
-----

  src/logging/logging.cpp 7386e5e8a2bbf9723790f4deac6f7a465753df49 

Diff: https://reviews.apache.org/r/13028/diff/


Testing
-------

Manual.

SIGPIPE:
W0729 19:54:08.992439 15650 logging.cpp:55] Received signal SIGPIPE; escalating to SIGABRT
*** Aborted at 1375127648 (unix time) try "date -d @1375127648" if you are using GNU date
***
PC: @     0x7f9ca40adb6d raise
*** SIGABRT (@0x3d22) received by PID 15650 (TID 0x7f9ca50d1730) from PID 15650; stack trace:
***
    @     0x7f9ca40adca0 (unknown)
    @     0x7f9ca40adb6d raise
    @     0x7f9ca47c06fb mesos::internal::logging::handler()
    @     0x7f9ca40adca0 (unknown)
    @     0x7f9ca40aa019 __pthread_cond_wait
    @     0x7f9ca491c5cb process::ProcessManager::wait()
    @     0x7f9ca492d712 process::wait()
    @           0x41bd69 main
    @     0x7f9ca29d09c4 __libc_start_main
    @           0x41ac99 (unknown)

SIGTERM:
Received signal SIGTERM; exiting.


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message