mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ross Allen" <ross...@mesosphe.re>
Subject Re: Review Request 13002: Search frameworks & executors successively to save concat
Date Sat, 27 Jul 2013 23:06:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13002/
-----------------------------------------------------------

(Updated July 27, 2013, 11:06 p.m.)


Review request for mesos and Ben Mahler.


Changes
-------

Ben, this is the update to my commit submitted in review https://reviews.apache.org/r/12879/


Repository: mesos-git


Description
-------

Search frameworks & executors successively to save concat

Array.concat creates a new Array, which in this case is used once to
find frameworks and executors and then thrown away. Instead the Arrays
can be searched successively in place without allocating more memory.

Original review: https://reviews.apache.org/r/12879/


Diffs
-----

  src/webui/master/static/js/controllers.js b9099e012e7893bb1213ab81f4d57160678bf75e 

Diff: https://reviews.apache.org/r/13002/diff/


Testing
-------


Thanks,

Ross Allen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message