mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ross Allen" <ross...@mesosphe.re>
Subject Re: Review Request 12879: Search frameworks & executors successively to save concat
Date Thu, 25 Jul 2013 22:19:36 GMT


> On July 25, 2013, 9:19 p.m., Ben Mahler wrote:
> > src/webui/master/static/js/controllers.js, lines 660-666
> > <https://reviews.apache.org/r/12879/diff/1/?file=326134#file326134line660>
> >
> >     Can you move these down to where they're used?

I defined them outside the scope of `var update = function() { ... }` because they don't need
access to the `update` function's scope. They only need access to the Controller's scope to
access the `$scope` variable.


- Ross


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12879/#review23873
-----------------------------------------------------------


On July 23, 2013, 8:52 p.m., Ross Allen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12879/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 8:52 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Search frameworks & executors successively to save concat
> 
> Array.concat creates a new Array, which in this case is used once to
> find frameworks and executors and then thrown away. Instead the Arrays
> can be searched successively in place without allocating more memory.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js dae12b61001ff0c7379169242e5d125ef6ca141b

> 
> Diff: https://reviews.apache.org/r/12879/diff/
> 
> 
> Testing
> -------
> 
> Rendered SlaveExecutor page to verify output didn't change with this commit.
> 
> 
> Thanks,
> 
> Ross Allen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message