mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 12847: Fixed Slave, Cloud and Retention strategy for Jenkins.
Date Wed, 24 Jul 2013 03:04:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12847/#review23730
-----------------------------------------------------------

Ship it!



jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosCloud.java
<https://reviews.apache.org/r/12847/#comment47605>

    Is ""+numExecutors a good node description?



jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosSlave.java
<https://reviews.apache.org/r/12847/#comment47606>

    I don't know what this stuff does, but ok :)


- Ben Mahler


On July 23, 2013, 8:22 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12847/
> -----------------------------------------------------------
> 
> (Updated July 23, 2013, 8:22 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Bunch of fixes.
> 
> 
> Diffs
> -----
> 
>   jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosCloud.java 63f218ba41cc80fd22a8f2b38de22776f1caf056

>   jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosRetentionStrategy.java 17da814cc094bbe06539dc81875ad732b18ae417

>   jenkins/src/main/java/org/jenkinsci/plugins/mesos/MesosSlave.java eed0ba3d2f58864b10fb219b9080a5a9d4b0ce31

>   jenkins/src/main/resources/org/jenkinsci/plugins/mesos/MesosSlave/configure-entries.jelly
24448a8325d1d680b4d22a336b5d5a42e7d869e1 
> 
> Diff: https://reviews.apache.org/r/12847/diff/
> 
> 
> Testing
> -------
> 
> make jenkins && mvn hpi:run
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message