mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 12740: Remove unused 'slaves' variable from controllers.js
Date Thu, 18 Jul 2013 23:40:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12740/#review23460
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On July 18, 2013, 8:04 p.m., Ross Allen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12740/
> -----------------------------------------------------------
> 
> (Updated July 18, 2013, 8:04 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> 'var slaves' was unused in controllers.js.
> 
> Original review: https://reviews.apache.org/r/12714/
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/12740/diff/
> 
> 
> Testing
> -------
> 
> Rendered each template to confirm none of them referenced the variable
> 
> 
> Thanks,
> 
> Ross Allen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message