mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ross Allen" <ross...@mesosphe.re>
Subject Review Request 12736: Wrap "app.js" in a closure
Date Thu, 18 Jul 2013 19:56:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12736/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos-git


Description
-------

Strict mode was applied at the top of "app.js", but because it wasn't wrapped it in a closure,
strict mode was applied globally. The closure will ensure the file doesn't unintentionally
leak any globals as well.

Original review: https://reviews.apache.org/r/12614/


Diffs
-----

  src/webui/master/static/js/app.js PRE-CREATION 

Diff: https://reviews.apache.org/r/12736/diff/


Testing
-------

* Rendered each template of the site in IE9, Firefox, and Chrome


Thanks,

Ross Allen


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message