mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Review Request 12601: Added a LIBPROCESS_STATISTICS_WINDOW environment variable.
Date Tue, 16 Jul 2013 23:14:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12601/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Repository: mesos


Description
-------

We were experiencing memory consumption issues due to the current implementation of Statistics.
This halves the window and adds a LIBPROCESS_STATISTICS_WINDOW environment variable for customizing
it.


Diffs
-----

  3rdparty/libprocess/src/process.cpp 3bd7015dbb91d350190fa044b30cc22c0e2f8e63 

Diff: https://reviews.apache.org/r/12601/diff/


Testing
-------

Manual:

$ LIBPROCESS_STATISTICS_WINDOW=5mintures ./3rdparty/libprocess/tests
WARNING: Logging before InitGoogleLogging() is written to STDERR
F0716 21:03:48.227066 47879 process.cpp:1524] LIBPROCESS_STATISTICS_WINDOW=5mintures is not
a valid duration: Unknown duration unit 'mintures'
*** Check failure stack trace: ***
Aborted
[bmahler@smfd-bkq-03-sr4 build]$ LIBPROCESS_STATISTICS_WINDOW=5mins ./3rdparty/libprocess/tests
[==========] Running 46 tests from 7 test cases.
[----------] Global test environment set-up.
[----------] 3 tests from TimeTest
[ RUN      ] TimeTest.Arithmetic
[       OK ] TimeTest.Arithmetic (0 ms)
[ RUN      ] TimeTest.Now
[       OK ] TimeTest.Now (0 ms)
[ RUN      ] TimeTest.Output
[       OK ] TimeTest.Output (1 ms)
[----------] 3 tests from TimeTest (1 ms total)

[----------] 4 tests from Statistics
[ RUN      ] Statistics.set
[       OK ] Statistics.set (0 ms)
[ RUN      ] Statistics.truncate
[       OK ] Statistics.truncate (10 ms)
[ RUN      ] Statistics.meter
[       OK ] Statistics.meter (1 ms)
[ RUN      ] Statistics.archive
[       OK ] Statistics.archive (13 ms)
[----------] 4 tests from Statistics (24 ms total)

[----------] 29 tests from Process
[ RUN      ] Process.event
[       OK ] Process.event (0 ms)
[ RUN      ] Process.future
[       OK ] Process.future (0 ms)
[ RUN      ] Process.associate
[       OK ] Process.associate (0 ms)
[ RUN      ] Process.onAny
[       OK ] Process.onAny (0 ms)
[ RUN      ] Process.then
[       OK ] Process.then (1 ms)
[ RUN      ] Process.chain
[       OK ] Process.chain (2 ms)
[ RUN      ] Process.spawn
[       OK ] Process.spawn (0 ms)
[ RUN      ] Process.dispatch
[       OK ] Process.dispatch (1 ms)
[ RUN      ] Process.defer1
[       OK ] Process.defer1 (1 ms)
[ RUN      ] Process.defer2
[       OK ] Process.defer2 (1 ms)
[ RUN      ] Process.defer3
[       OK ] Process.defer3 (0 ms)
[ RUN      ] Process.handlers
[       OK ] Process.handlers (0 ms)
[ RUN      ] Process.expect
[       OK ] Process.expect (0 ms)
[ RUN      ] Process.action
[       OK ] Process.action (1 ms)
[ RUN      ] Process.inheritance
[       OK ] Process.inheritance (0 ms)
[ RUN      ] Process.thunk
[       OK ] Process.thunk (1 ms)
[ RUN      ] Process.delegate
[       OK ] Process.delegate (0 ms)
[ RUN      ] Process.delay
[       OK ] Process.delay (0 ms)
[ RUN      ] Process.order
[       OK ] Process.order (0 ms)
[ RUN      ] Process.donate
[       OK ] Process.donate (0 ms)
[ RUN      ] Process.exited
[       OK ] Process.exited (0 ms)
[ RUN      ] Process.select
[       OK ] Process.select (0 ms)
[ RUN      ] Process.collect
[       OK ] Process.collect (1 ms)
[ RUN      ] Process.settle
[       OK ] Process.settle (41 ms)
[ RUN      ] Process.pid
[       OK ] Process.pid (0 ms)
[ RUN      ] Process.listener
[       OK ] Process.listener (0 ms)
[ RUN      ] Process.executor
[       OK ] Process.executor (0 ms)
[ RUN      ] Process.remote
[       OK ] Process.remote (1 ms)
[ RUN      ] Process.async
[       OK ] Process.async (2 ms)
[----------] 29 tests from Process (55 ms total)

[----------] 3 tests from IO
[ RUN      ] IO.Poll
[       OK ] IO.Poll (0 ms)
[ RUN      ] IO.Read
[       OK ] IO.Read (2 ms)
[ RUN      ] IO.BufferedRead
[       OK ] IO.BufferedRead (18 ms)
[----------] 3 tests from IO (20 ms total)

[----------] 2 tests from HTTP
[ RUN      ] HTTP.Endpoints
[       OK ] HTTP.Endpoints (4 ms)
[ RUN      ] HTTP.Encode
[       OK ] HTTP.Encode (0 ms)
[----------] 2 tests from HTTP (4 ms total)

[----------] 2 tests from Encoder
[ RUN      ] Encoder.Response
[       OK ] Encoder.Response (0 ms)
[ RUN      ] Encoder.AcceptableEncodings
[       OK ] Encoder.AcceptableEncodings (0 ms)
[----------] 2 tests from Encoder (0 ms total)

[----------] 3 tests from Decoder
[ RUN      ] Decoder.Request
[       OK ] Decoder.Request (0 ms)
[ RUN      ] Decoder.RequestHeaderContinuation
[       OK ] Decoder.RequestHeaderContinuation (0 ms)
[ RUN      ] Decoder.Response
[       OK ] Decoder.Response (0 ms)
[----------] 3 tests from Decoder (0 ms total)

[----------] Global test environment tear-down
[==========] 46 tests from 7 test cases ran. (104 ms total)
[  PASSED  ] 46 tests.

  YOU HAVE 1 DISABLED TEST

[bmahler@smfd-bkq-03-sr4 build]$ LIBPROCESS_STATISTICS_WINDOW=5mins ./3rdparty/libprocess/tests


Thanks,

Ben Mahler


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message