mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 12520: Added timing information to Scheduler and Executor callbacks when verbose logging is enabled.
Date Fri, 12 Jul 2013 22:41:39 GMT


> On July 12, 2013, 10:35 p.m., Vinod Kone wrote:
> > src/exec/exec.cpp, line 199
> > <https://reviews.apache.org/r/12520/diff/1/?file=320929#file320929line199>
> >
> >     why not make this instance variable?

Then I'd have to ensure it's stopped which would require a second conditional block on each
timing, and Stopwatch is a light struct so it shouldn't be a performance issue.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12520/#review23112
-----------------------------------------------------------


On July 12, 2013, 9:04 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12520/
> -----------------------------------------------------------
> 
> (Updated July 12, 2013, 9:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This only performs the additional work for timing when verbose logging is enabled.
> 
> 
> Diffs
> -----
> 
>   src/exec/exec.cpp 116168f6a5a75f0f44e7db627ecbf2bbe29727db 
>   src/sched/sched.cpp 7ea82e547c612159c9fa24fb6d62e3d2b5f11982 
> 
> Diff: https://reviews.apache.org/r/12520/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message